Attention is currently required from: Tim Chu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48946 )
Change subject: mb/ocp/deltalake: Override DDR frequency limit via VPD variable
......................................................................
Patch Set 7:
(5 comments)
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/48946/comment/4ff498dd_cc5db42c
PS7, Line 84: * 0xf:DDR_2666, 0x11:DDR_2933, 0x13:DDR_3200
Please use macros or enums.
https://review.coreboot.org/c/coreboot/+/48946/comment/38f1cf3e_0cf1777f
PS7, Line 88: > ARRAY_SIZE(limit) - 1
Use >= instead of - 1?
https://review.coreboot.org/c/coreboot/+/48946/comment/17e77788_cd3763fe
PS7, Line 89: BIOS_DEBUG
This should be at least a warning, even an error?
https://review.coreboot.org/c/coreboot/+/48946/comment/a33874f2_59710864
PS7, Line 93: BIOS_DEBUG
Maybe: BIOS_INFO
https://review.coreboot.org/c/coreboot/+/48946/comment/3dbefa31_c63eec3e
PS7, Line 96: BIOS_INFO
Warning level?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1232feae5090420d8fa42596b46f2d4dcaf9d635
Gerrit-Change-Number: 48946
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 29 Mar 2021 09:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment