Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48575 )
Change subject: soc/intel/skylake: Drop always-zero PowerLimit4 dt setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48575/2/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/48575/2/src/soc/intel/skylake/chip....
PS2, Line 306: tconfig->PowerLimit4 = 0
coreboot configures PL4 in `soc/intel/common/block/power_limit/power_limit.c`. […]
I'm preserving the original behavior with this patch, since I can't test the consequences of removing this write entirely.
If anyone wants to drop it, please do so in a different patch. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad94538c5465347b37a99c6c9f20988168661593
Gerrit-Change-Number: 48575
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Dec 2020 22:33:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment