Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30553 )
Change subject: src/superio/ite/common: Prepare for ITE IT8786E SuperIO ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/30553/2/src/superio/ite/common/env_ctrl.h File src/superio/ite/common/env_ctrl.h:
https://review.coreboot.org/#/c/30553/2/src/superio/ite/common/env_ctrl.h@53 PS2, Line 53: /* ITE IT8786E has following 16Hz smoothing:
hmmm, maybe put it into a definition? […]
Done
https://review.coreboot.org/#/c/30553/2/src/superio/ite/common/env_ctrl.h@60 PS2, Line 60: #define ITE_EC_FAN_PWM_SMOOTHING_4HZ (3 << 6)
or maybe give all of them a different prefix? e.g. […]
Done
https://review.coreboot.org/#/c/30553/2/src/superio/ite/common/env_ctrl.c File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/#/c/30553/2/src/superio/ite/common/env_ctrl.c@17... PS2, Line 170: if (IS_ENABLED(CONFIG_SUPERIO_ITE_ENV_CTRL_7BIT_SLOPE_REG)) {
CONFIG(
Done
https://review.coreboot.org/#/c/30553/2/src/superio/ite/common/env_ctrl_chip... File src/superio/ite/common/env_ctrl_chip.h:
https://review.coreboot.org/#/c/30553/2/src/superio/ite/common/env_ctrl_chip... PS2, Line 103:
add comment what it does
Done