EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37594 )
Change subject: libpayload/drivers/i8042: Add AT translated Keyboard support ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37594/7/payloads/libpayload/Kconfig File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/37594/7/payloads/libpayload/Kconfig... PS7, Line 346: config PC_KEYBOARD_IGNORE_INIT_FAILURE : bool "Ignore keyboard failures during init and always add input device" : default n
Isn't this config effectively obsolete now?
I will remove this after overlay CL is merged.
https://review.coreboot.org/c/coreboot/+/37594/7/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37594/7/payloads/libpayload/drivers... PS7, Line 321: if (!i8042_cmd(I8042_CMD_WR_CMD_BYTE))
What if this fails? Don't you want to return 0 in that case?
I am not sure. I think it's okay for check. In i8042 it check all the command as well. I will patch it.