Attention is currently required from: Francois Toguo Fotso, Martin Roth, Tim Wawrzynczak, Duncan Laurie, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49943 )
Change subject: soc/intel/tigerlake: Add CrashLog implementation for intel TGL.
......................................................................
Patch Set 9:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49943/comment/4c0dd139_1094bea0
PS9, Line 7: soc/intel/tigerlake: Add CrashLog implementation for intel TGL.
Please remove the period/dot at the end of commit message summaries.
https://review.coreboot.org/c/coreboot/+/49943/comment/30f464cf_7c7da40c
PS9, Line 11: The state of relevant registers is preserved across a warm reset.
Please add a reference to the specification.
https://review.coreboot.org/c/coreboot/+/49943/comment/78082b88_96da187d
PS9, Line 12:
1. Why is it SOC specific?
2. Please add documentation.
https://review.coreboot.org/c/coreboot/+/49943/comment/4784d5d0_808c95fa
PS9, Line 14: TEST=CrashLog data generated, extracted, processed, decoded sucessfully on delbin.
Please add documentation, or add the utilities and how you called them here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3763cebcd1178709cc8597710bf062a30901809
Gerrit-Change-Number: 49943
Gerrit-PatchSet: 9
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 28 Jan 2021 09:27:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment