Attention is currently required from: Ravindra N. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57757 )
Change subject: Alderlake: Enable _CPC nominal performance and _CPC nominal frequency in performance scale ......................................................................
Patch Set 1:
(34 comments)
File src/cpu/intel/common/common_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/5ece90f0_785c4f6b PS1, Line 268: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/990306bc_f51f2f02 PS1, Line 269: msr.addrl = MSR_PLATFORM_INFO; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/2b1328ab_d3826046 PS1, Line 271: /* code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/dc65faac_e4ab26aa PS1, Line 272: * Nominal Performance -> Maximum Non-Turbo Ratio: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/cc760b34_5b7f24f3 PS1, Line 273: * ResourceTemplate(){Register(FFixedHW, 0x08, 0x08, 0xce, 0x04,)}, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/b5798cd7_92794704 PS1, Line 274: */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/5de7ef08_c2cf58be PS1, Line 275: msr.bit_offset = 8; code indent should use tabs where possible
File src/soc/intel/common/block/acpi/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/d563c5b1_f4dc679a PS1, Line 27: #define ScalingFactorBigCore 100 trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/c57894ec_1ae65034 PS1, Line 40: * function gets the required nominal frequency and based on the trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/a36b0d64_7541359b PS1, Line 41: * core type performance scaling factor calculated and performance trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/47bc903a_ce7931cd PS1, Line 399: if(core_id == 0 || core_id == 1) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/31c4b11b_11ea71d6 PS1, Line 399: if(core_id == 0 || core_id == 1) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/fedb7eb5_bbd9d494 PS1, Line 406: int get_nominal_frequency() Bad function definition - int get_nominal_frequency() should probably be int get_nominal_frequency(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/fe1555d4_c6e1f30b PS1, Line 414: int nominal_frequency = get_nominal_frequency(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/79bedc86_cf3f1ef1 PS1, Line 414: int nominal_frequency = get_nominal_frequency(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/680818db_404a4566 PS1, Line 417: if(!type) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/49ee8ae9_ea82cc4b PS1, Line 417: if(!type) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/5968aed4_0aa51789 PS1, Line 417: if(!type) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/19bab254_23371a8e PS1, Line 417: if(!type) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/c6b6767f_fd06ddbb PS1, Line 418: config->regs[3].addrh = (u16) ((nominal_frequency * ScalingFactorSmallCore) / 100); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/ac6f0e4d_c5242cec PS1, Line 419: } else { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/d904cf70_1f9e414d PS1, Line 419: } else { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/cc75d453_aa553e5f PS1, Line 420: config->regs[3].addrh = (u16) ((nominal_frequency * ScalingFactorBigCore) / 100); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/d562853c_95b5025b PS1, Line 421: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/2c29cd3a_0717740b PS1, Line 421: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/4961c9d8_f832a863 PS1, Line 423: printk(BIOS_DEBUG, "hybrid_core type=%d, nominal_frequency=%d, config->regs[3].addrh=%d, config->regs[3].addrl=%d, ((nominal_frequency * ScalingFactorSmallCore) / 100) = %d, config->regs[0].addrl=%d\n", type, nominal_frequency, config->regs[3].addrh, config->regs[3].addrl, ((nominal_frequency * ScalingFactorSmallCore) / 100), config->regs[0].addrl); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/780d4e0b_c1d74f03 PS1, Line 436: if(version <= 2) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/c2db6817_c871fcb2 PS1, Line 436: if(version <= 2) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/a97a4952_75441fa6 PS1, Line 437: cpu_init_cppc_config(&cppc_config, CPPC_VERSION_2); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/302933c2_ea091541 PS1, Line 437: cpu_init_cppc_config(&cppc_config, CPPC_VERSION_2); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/075e7e37_22274391 PS1, Line 437: cpu_init_cppc_config(&cppc_config, CPPC_VERSION_2); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/aa40d595_1a043181 PS1, Line 441: acpigen_write_CPPC_package(&cppc_config); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/0f862e53_1a900da2 PS1, Line 441: acpigen_write_CPPC_package(&cppc_config); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128532): https://review.coreboot.org/c/coreboot/+/57757/comment/5ff0c0ce_17ba8b41 PS1, Line 443: trailing whitespace