4 Feb
2019
4 Feb
'19
12:46 p.m.
Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31208 )
Change subject: ec/google/wilco: Add virtual button support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31208/4/src/ec/google/wilco/acpi/event.asl File src/ec/google/wilco/acpi/event.asl:
https://review.coreboot.org/#/c/31208/4/src/ec/google/wilco/acpi/event.asl@8... PS4, Line 85: If (EBIT (E2OR, Arg0)) { Does this work with the OEM's tristate enum for orientations that they want to use? Or will this potential change based on the final outcome of that discussion?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d5dc985a3cfb1d01ff164c4e67f17e6b1cdd619
Gerrit-Change-Number: 31208
Gerrit-PatchSet: 4
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jett Rink jettrink@google.com
Gerrit-Reviewer: Matt Delco delco@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alex Thiessen alex.thiessen.de+coreboot@gmail.com
Gerrit-CC: Jett Rink jettrink@chromium.org
Gerrit-Comment-Date: Mon, 04 Feb 2019 15:46:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment