Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33799 )
Change subject: src/lib/hexdump: Use size_t for indices
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c
File src/lib/hexdump.c:
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c@67
PS6, Line 67: int
Why? […]
I suppose the argument could be made that since its value at the end of the while loop will be the original value of len (since it is incremented every time len is decremented), that this should also be a size_t (since the range of an int is less than the range of a size_t).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29a7ae8c499bb1e8ab7c8741b2dfb7663d82a362
Gerrit-Change-Number: 33799
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 20 Jul 2019 05:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment