Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32801 )
Change subject: mb/google/hatch: Disable HECI device
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32801/4/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32801/4/src/mainboard/google/hatch/variants/...
PS4, Line 49: # Disable Heci1 device
: register "Heci1Disabled" = "1"
Right now, the only setting close to this in cannonlake's chip.h is: […]
https://review.coreboot.org/c/coreboot/+/32992/4 adds Heci1Disabled config.
Above CL is failing since the current header in 3rdparty/fsp git does not have the Heci1Disabled member in FSP_M header. The GitHub has the updated header and needs to be synced into 3rdparty/fsp.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifaa09ef0cee77a15c33dc415f465ac735c0dce2b
Gerrit-Change-Number: 32801
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 May 2019 16:11:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment