Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31351 )
Change subject: soc/intel/apl: Add chip.h setting for PCIe ASPM
......................................................................
Patch Set 3: Code-Review-2
Will have to check if this is really needed. If there were
documentation about the UPDs, I could tell: i.e. does this
enable ASPM? or does it only enabled its capabilities? In
the latter, coreboot could handle it on its own.
Blocking until I figured this out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I169722c3c63be66772cb57a429ec7b83230fa234
Gerrit-Change-Number: 31351
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 18 Mar 2019 12:08:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment