Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33986 )
Change subject: util/cbfstool: Use 64 bit integers in multiplications ......................................................................
Patch Set 1:
(1 comment)
I'm somewhat confused how multiplying two u16 into an s32 could cause overflow or sign issues? This seems unnecessary. (Also, if you do want to do this, note that size_t is dependent on the host architecture which is not guaranteed to be x86_64. You should use an explicit-width type like Elf64_Off or uint64_t.)
https://review.coreboot.org/#/c/33986/1/util/cbfstool/elfheaders.c File util/cbfstool/elfheaders.c:
https://review.coreboot.org/#/c/33986/1/util/cbfstool/elfheaders.c@265 PS1, Line 265: buffer_splice(&b, in, ehdr->e_phoff, (size_t)ehdr->e_phentsize * ehdr->e_phnum); Stick to 80 char limit, please (at least until the whole file is converted to 96)