Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )
Change subject: mainboard/google/volteer: Enable long cr50 ready pulses ......................................................................
Patch Set 15: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/44359/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44359/15//COMMIT_MSG@24 PS15, Line 24: It would be good to also mention the change in gpio_pm_override.
https://review.coreboot.org/c/coreboot/+/44359/15/src/mainboard/google/volte... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44359/15/src/mainboard/google/volte... PS15, Line 10: #include <halt.h> Is this required?
https://review.coreboot.org/c/coreboot/+/44359/15/src/mainboard/google/volte... PS15, Line 11: #include <intelblocks/cse.h> Is this required?
https://review.coreboot.org/c/coreboot/+/44359/15/src/mainboard/google/volte... PS15, Line 40: 5 * sizeof(cfg->gpio_pm[0]) nit: just `sizeof(cfg->gpio_pm)` should work.