Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28876 )
Change subject: src/mb: Remove dead code
......................................................................
Patch Set 2:
Ah, looks like my doubts were misplaced. It should have compiled.
The
errors in PS#3 were introduced by the patch...
I wouldn't object if we drop the code but if, we should also drop
the
then obsolete implementation. I would ack it, if you think it's the
right thing. But I can't ack it if you are just following my
examples
what could be done.
I think that we can drop it ...
--
To view, visit
https://review.coreboot.org/28876
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149
Gerrit-Change-Number: 28876
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Oct 2018 08:15:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No