Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33842 )
Change subject: src/superio/nuvoton: Add support for NCT5539D
......................................................................
Patch Set 16: Code-Review+1
Patch Set 15: Code-Review+1
Looks good to me. I'll wait with merging this until the patch adding the board using this SIO chip is on the review system and the build bot is happy with that patch.
Only put a +1 and not a +2 so that it won't accidentally get merged before the mainboard is sort-of ready; the patch is now in a state where I'm happy with it though
Agreed. Gave a +1 for the same reason.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e979bde53ce3dac1a4f74e7e51a3c6a0149051c
Gerrit-Change-Number: 33842
Gerrit-PatchSet: 16
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 28 Jul 2019 18:16:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment