Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36033 )
Change subject: inteltool: gemini lake gpio support + UHD 605 graphics detection
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36033/2/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/36033/2/util/inteltool/inteltool.h@...
PS2, Line 267: PCI_DEVICE_ID_INTEL_GLK
nit: The other device IDs end in 'LPC', is the GLK device ID for LPC as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8b04e58359bb8ff17318f86b6d9a57def94a401
Gerrit-Change-Number: 36033
Gerrit-PatchSet: 2
Gerrit-Owner: coreboot@s.paape.io
Gerrit-Assignee: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: coreboot@s.paape.io
Gerrit-Comment-Date: Tue, 11 Feb 2020 14:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment