Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38650 )
Change subject: lenovo/t440p: fix keyboard backlight
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38650/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38650/1//COMMIT_MSG@8
PS1, Line 8:
Please elaborate in the commit message body. What is broken, and how do you fix it.
Done
https://review.coreboot.org/c/coreboot/+/38650/1/src/mainboard/lenovo/t440p/...
File src/mainboard/lenovo/t440p/cmos.layout:
https://review.coreboot.org/c/coreboot/+/38650/1/src/mainboard/lenovo/t440p/...
PS1, Line 106: has
have
Done
https://review.coreboot.org/c/coreboot/+/38650/1/src/mainboard/lenovo/t440p/...
PS1, Line 107: Both
cmos. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4c2b1591d26e2bb33f9549e3933efe9a6e0b043
Gerrit-Change-Number: 38650
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dennis Witzig
dennis@wtzg.de
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 12:40:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dennis Witzig
dennis@wtzg.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment