Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40951 )
Change subject: soc/amd/common/block/lpc: Add lpc_disable_spi_rom_sharing ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40951/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/40951/1/src/soc/amd/common/block/lp... PS1, Line 306: u8 byte; I think I'd prefer this:
if (!CONFIG(PROVIDES_ROM_SHARING)) dead_code();
That way we aren't guarding valid code with macros and we're getting link time errors.