Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39766 )
Change subject: drivers/i2c/nct7802y: Configure remote diodes and local sensor ......................................................................
Patch Set 31:
(3 comments)
Thanks for the review!
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/c... File src/drivers/i2c/nct7802y/chip.h:
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/c... PS30, Line 68: enum nct7802y_sensor_mode rtd1;
Nit, we use arrays, usually.
Hi Niсo! Thanks for your comments. I reworked this patch. please review again
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/n... File src/drivers/i2c/nct7802y/nct7802y.h:
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/n... PS30, Line 15: #define MODE_SELECTION_EN_LTD(x) (x << 6)
Nit, if it's a single bit, it doesn't need a parameter.
Done
https://review.coreboot.org/c/coreboot/+/39766/30/src/drivers/i2c/nct7802y/n... PS30, Line 17: #define MODE_SELECTION_RTD2(x) (x << 2)
Please guard macro parameters with braces as done below.
These macros have been removed