Attention is currently required from: Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: verify size of memchipinfo structure ......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3: HI Julius, I have updated comments. please let me know if any thing i have missed here.
Regards, Ravi
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/ba39bf13_6731340a PS1, Line 51: sizeof(struct mem_chip_info)
No you didn't.
Done
https://review.coreboot.org/c/coreboot/+/63026/comment/abb6a702_53200cbb PS1, Line 55: memchip
No you didn't.
Done
https://review.coreboot.org/c/coreboot/+/63026/comment/27fb61fe_81fedac0 PS1, Line 186: mem_chip_addr, sizeof(mem_chip_addr), 0);
No you didn't.
Done