Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35967 )
Change subject: mb/google/poppy/variant/nocturne: don't invert GPP_D17
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35967/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35967/1//COMMIT_MSG@12
PS1, Line 12:
What does the schematic say?
The schematic just shows that this GPIO goes to a GPIO on the EC.
I agree that this commit message makes it sound like there may not be a good understanding of what actually caused the error. I trust that Nick has a better explanation and was just simplifying things for the sake of a simple commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1408ef6ea92f6b31a9f3eee8720954af3a7c382
Gerrit-Change-Number: 35967
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Gwendal Grignou
gwendal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Yicheng Li
yichengli@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aseda Aboagye
aaboagye@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yicheng Li
yichengli@google.com
Gerrit-Comment-Date: Sun, 27 Oct 2019 23:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment