[coreboot-gerrit] Change in coreboot[master]: soc/amd/psp_verstage: Init TPM on S0i3 resume

[Rob Barnes (Code Review)]

Attention is currently required from: Raul Rangel, Andrey Pronin, Kangheui Won, Julius Werner, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58870 )

Change subject: soc/amd/psp_verstage: Init TPM on S0i3 resume
......................................................................

Patch Set 11:

(3 comments)

File src/soc/amd/common/psp_verstage/psp_verstage.c:

https://review.coreboot.org/c/coreboot/+/58870/comment/e18b32dc_a4985c27 
PS9, Line 224: rv = verstage_soc_early_init();
             : 	if (rv) {
             : 		printk(BIOS_DEBUG, "verstage_soc_early_init failed rv:%d\n", rv);
             : 		return POSTCODE_INIT_TPM_FAILED;
             : 	}
> Maybe we fork too early in Main. […]

Done

https://review.coreboot.org/c/coreboot/+/58870/comment/3a1970e1_dd6c69c1 
PS9, Line 230: 	verstage_mainboard_espi_init();
             : 	/* verstage_soc_init should init i2c and eSPI */
             : 	verstage_soc_init();
             : 	/*
             : 	 * verstage_mainboard_tpm_init may check board_id which depends on eSPI,
             : 	 * so it must come after verstage_mainboard_espi_init and verstage_soc_init.
             : 	 */
             : 	verstage_mainboard_tpm_init();
> Can we just make this the default flow? […]

I moved TPM and eSPI gpios out of esarly_gpio_table as suggested.

I did not move TPM and eSPI init into verstage_mainboard_early_init because I want to avoid initializing the early_gpio_table. I also want to avoid having two calls to svc_get_boot_mode.

https://review.coreboot.org/c/coreboot/+/58870/comment/386c4d21_77989859 
PS9, Line 280:
> nit: space

Done