Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: superio/common: Add ssdtgen for generic SuperIOs
......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33033/21/src/superio/common/ssdt.c
File src/superio/common/ssdt.c:
https://review.coreboot.org/c/coreboot/+/33033/21/src/superio/common/ssdt.c@...
PS21, Line 155: superio_common_get_dev_hid
This won't link if your board has multiple SIO's and therefore multiple definitions of this function. Would extending pnp_info be an option?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2716ae0580d68e5d4fcc484cb1648a2cdc1f4ca0
Gerrit-Change-Number: 33033
Gerrit-PatchSet: 21
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 18 Aug 2019 06:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment