Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37514 )
Change subject: soc/intel/skylake: Add option to control microcode update inclusion
......................................................................
Patch Set 5:
Thinking about I was wondering if it would make more sense to reverse the logic. So if you have the CPU_MICROCODE_CBFS_DEFAULT_BINS you will be provided the option to remove SKYLAKE microcode e.g. This would make it easier to control from the mainboard level using a select and I think it would be more obvious to a user to understand what happens.
Please let me know what you think.
Sounds reasonable. But I wonder what would be better: a) try to add
Kconfig options for all possible cases, or b) let the mainboard's
Makefile override the paths.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa36c2846b2279a2eb2b61e6c97d6c89d0736f55
Gerrit-Change-Number: 37514
Gerrit-PatchSet: 5
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 23 Dec 2019 15:41:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment