T Michael Turney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32288 )
Change subject: qualcomm: Add QCLib interface support to common/ ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/32288/4/src/soc/qualcomm/common/qclib.c File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/#/c/32288/4/src/soc/qualcomm/common/qclib.c@30 PS4, Line 30: #define QCSDI_NAME "/qcsdi"
nit: change these to be inline as well now?
Ack
https://review.coreboot.org/#/c/32288/4/src/soc/qualcomm/common/qclib.c@128 PS4, Line 128: size_t size;
Oh, wait, actually, this is bad. This must be ssize_t. […]
Ack
https://review.coreboot.org/#/c/32288/4/src/soc/qualcomm/common/qclib.c@175 PS4, Line 175: (uint64_t)
nit: could just use %p and avoid the cast
Ack