Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32725 )
Change subject: Replace ENV_RAMSTAGE with ENV_PAYLOAD_LOADER
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/32725/7/src/include/stddef.h
File src/include/stddef.h:
https://review.coreboot.org/#/c/32725/7/src/include/stddef.h@25
PS7, Line 25: * The devicetree data structures are only mutable in ENV_PAYLOAD_LOADER.
Done
looks like const devicetree won't work in this model because acpi table creation function pretty much designed for !const devicetree structure. if we wish to make use of const devicetree in acpi table creation then the amount of code changes will be very high.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib54ece7b9e5f281f8a092dc6f38c07406edfa5fa
Gerrit-Change-Number: 32725
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 May 2019 00:21:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ron minnich
rminnich@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment