Attention is currently required from: Tarun Tuli.
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69969 )
Change subject: soc/intel/alderlake: Use common code CSE-Lite API for WP information ......................................................................
soc/intel/alderlake: Use common code CSE-Lite API for WP information
This patch drops the local implementation `log_me_ro_write_protection_info` and adopts the API from IA common code (cse_lite.c).
BUG=none TEST=Able to compile the cse_lite.c file for google/kano without any error.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I087ffb8ac94f14a6bd7f2bf6bb907c4047dc9899 --- M src/soc/intel/alderlake/me.c 1 file changed, 19 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/69969/1
diff --git a/src/soc/intel/alderlake/me.c b/src/soc/intel/alderlake/me.c index 4937ced..8b5e94f 100644 --- a/src/soc/intel/alderlake/me.c +++ b/src/soc/intel/alderlake/me.c @@ -2,7 +2,6 @@
#include <bootstate.h> #include <intelblocks/cse.h> -#include <intelblocks/spi.h> #include <console/console.h> #include <soc/me.h> #include <stdint.h> @@ -88,28 +87,6 @@ } __packed fields; };
-static void log_me_ro_write_protection_info(bool mfg_mode) -{ - bool cse_ro_wp_en = is_spi_wp_cse_ro_en(); - - printk(BIOS_DEBUG, "ME: WP for RO is enabled : %s\n", - cse_ro_wp_en ? "YES" : "NO"); - - if (cse_ro_wp_en) { - uint32_t base, limit; - spi_get_wp_cse_ro_range(&base, &limit); - printk(BIOS_DEBUG, "ME: RO write protection scope - Start=0x%X, End=0x%X\n", - base, limit); - } - - /* - * If manufacturing mode is disabled, but CSE RO is not write protected, - * log error. - */ - if (!mfg_mode && !cse_ro_wp_en) - printk(BIOS_ERR, "ME: Write protection for CSE RO is not enabled\n"); -} - static bool is_manuf_mode(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6) { /* @@ -195,7 +172,7 @@ hfsts6.fields.txt_support ? "YES" : "NO");
if (CONFIG(SOC_INTEL_CSE_LITE_SKU)) - log_me_ro_write_protection_info(manuf_mode); + cse_log_ro_write_protection_info(manuf_mode); }
BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_EXIT, print_me_fw_version, NULL);