Attention is currently required from: Matt DeVillier, Sean Rhodes.
Jérémy Compostella has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86400?usp=email )
Change subject: drivers/usb/acpi: Account for GPIO polarity
......................................................................
Patch Set 7:
(1 comment)
File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/86400/comment/eeb371fb_cd3dab88?usp... :
PS7, Line 95: void acpi_device_intel_bt_common(const struct acpi_gpio *reset_gpio,
: const struct acpi_gpio *enable_gpio);
You swapped the two variables which technically seems like a good idea as it improves consistency but it then needs to be reflected everywhere it is being used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86400?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib481d49d536b702fef149af882209501c61de6da
Gerrit-Change-Number: 86400
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 13 Feb 2025 22:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No