[coreboot-gerrit] [XS] Change in coreboot[main]: acpi.c: Fix generating pointer to cb_tables located >4G

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Benjamin Doron, Eric Lai, Felix Held, Lance Zhao, Maximilian Brune.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76181?usp=email )

Change subject: acpi.c: Fix generating pointer to cb_tables located >4G
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS2:
> I'm not sure what you mean. There is no 64bit equivalent of Memory32Fixed in ACPI.

Right, but Memory32Fixed is also just a shorthand for a resource report, IIRC.
So what I meant, I guess, was that we could have a acpigen_write_mem64fixed()
that does exactly what you do on the else path, just shares the interface with
the mem32 version.

OTOH, now that I looked into how the functions are implemented, I noticed
acpigen_resource_producer_mmio() already has a 32-bit check. So the cleanest
C code would probably be to just call that unconditionally (but would waste
a few bytes in the SSDT in the 32-bit case).

(obviously there are too many ways to do it)