Attention is currently required from: Martin Roth, Patrick Rudolph, Christian Walter.
Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44772 )
Change subject: mb/prodrive/hermes/hda_verb: Update verb table for latest board revision
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44772/comment/bbdd4dd4_0e68de97
PS8, Line 11: For board revision R02 and older use the existing verb tables.
should be R03. R04 are the only boards with the new audio mapping. R03 still use the old mapping.
https://review.coreboot.org/c/coreboot/+/44772/comment/473c9c83_2beba969
PS8, Line 13: For revisions newer than R02 use the new verb tables and also
should also be R03
File src/mainboard/prodrive/hermes/variants/r03/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/comment/9a5a81d5_4b605bb5
PS8, Line 9: static const u32 r03_verb_data[] = {
should be R04, as should the directory
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24ea9149eb2cddb815ff82744a351c926a94aaef
Gerrit-Change-Number: 44772
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Tue, 23 Feb 2021 13:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment