Attention is currently required from: Felix Singer, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50797 )
Change subject: soc/intel/cannonlake: Add devicetree setting to disable turbo
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50797/comment/e6ba68dc_16e93248
PS2, Line 11:
I personally don't see any reason, however somebody else might have a reason. […]
The devicetree can be updated at run-time, like CB:50798 does. This is very flexible: mainboards can choose to statically disable turbo in the devicetree itself, or disable turbo depending on run-time configuration settings.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia23ce4d589b5ecc5515474eea52a40788ae3d3b5
Gerrit-Change-Number: 50797
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 18 Feb 2021 09:48:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment