[coreboot-gerrit] Change in coreboot[master]: [NOTFORMERGE] soc/intel exit_car.S

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35187 )

Change subject: [NOTFORMERGE] soc/intel exit_car.S
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35187/2/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/car/exit_car.S:

https://review.coreboot.org/c/coreboot/+/35187/2/src/soc/intel/common/block/... 
PS2, Line 48: 	/* Disable cache  ??? */
Transactions would still hit in the cache even if cache is disabled.

https://review.coreboot.org/c/coreboot/+/35187/2/src/soc/intel/common/block/... 
PS2, Line 62: 	/* maybe redundant ? */
Not necessarily. What were you assuming at this point? valid cache lines do not become invalid on a cache disable operation.