Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters
......................................................................
Patch Set 56: -Code-Review
I did a timeless build (make BUILD_TIMELESS=1 -j 8) for one mainboard of each soc/southbridge that uses amdfwtool and it resulted in identical images for the following platforms:
* picasso: amd/mandolin
* merlinfalcon: amd/padmelon
* prariefalcon: amd/padmelon
* avalon: pcengines/apu2
* bolton/kern: no mainboard in tree, so I couldn't test
* hudson: asus/f2a85-m
* yangtze: asrock/imb-a180
but resulted in different binaries on the following platform:
* stoneyridge: amd/gardenia
So this patch does change the resulting coreboot.rom for stoneyridge, which shouldn't be the case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icae73d0730106aab687486e555ba947796e5e757
Gerrit-Change-Number: 42859
Gerrit-PatchSet: 56
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Dave Frodin
dave.frodin@se-eng.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 16:32:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment