15 Jun
2019
15 Jun
'19
1:49 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33198 )
Change subject: Makefile.inc: Add a class 'all' to link files in all stage ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/33198/7/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/#/c/33198/7/src/arch/x86/Makefile.inc@117 PS7, Line 117: bootblock-srcs += $(all-srcs) I'd put this in basedir Makefile.inc, but our makefiles seem to fragile for that (or my make knowledge is lacking).
--
To view, visit https://review.coreboot.org/c/coreboot/+/33198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955dd2dc22cb3cfc4fdf1198cfd32f56475f97c9
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 15 Jun 2019 20:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment