Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46054 )
Change subject: mb/intel/adlrvp: Add initial ADL-P mainboard code ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/board_info.txt:
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... PS3, Line 6: y
Nice, but I see that cros-flashrom treats everything starting from Sunrise Point the same. There's differences in descriptor contents starting from Cannon Point (300-series PCH), and upstream flashrom handles these chipsets slightly differently to report the correct information. flashrom can use the descriptor contents as a layout file, but needs to be able to parse it correctly.
Unfortunately I don't have any SPI Programming Guide for ADL. I see that TGL-LP has the FLMAP3 register, which contains the descriptor Major and Minor revision IDs. If TGL-LP and ADL have the same descriptor revision IDs, then I imagine the rest of fields would be the same, which would be good enough to add descriptor support to upstream flashrom.
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... PS3, Line 16:
will add in incremental patch :) as off now added only till booting romstage early.
OK, please mention this in the commit message.