Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35604 )
Change subject: util/mb/googl/hatch: update CRC calculation for correctness
......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Interesting catch, looks like it's only an issue for older versions of the library, https://docs.python.org/3/library/zlib.html
Given that the GBB_HWID code may be used outside the chroot (for example, to check the validity of GBB_HWID strings, see b/140067412), it seemed like a good idea to put the fix in even though it's correct in the chroot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92f9ce1ceb7450f90b89c94e0ace6f79a9419b42
Gerrit-Change-Number: 35604
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 15:45:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment