1 Nov
2019
1 Nov
'19
2:03 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36504 )
Change subject: mb/facebook/fbg1701: Add public key to bootblock_verify_list ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36504/5/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/board_verified_boot.c:
https://review.coreboot.org/c/coreboot/+/36504/5/src/mainboard/facebook/fbg1... PS5, Line 19: the bootblock will not measure the : * items to the TPM This seems to contradict the commit message that the key ends up in PCR0, or is the same structure used in a later stage to report post-hoc what was booted?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36504
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85fd391294db0ea796001720c2509f797be5aedf
Gerrit-Change-Number: 36504
Gerrit-PatchSet: 5
Gerrit-Owner: Wim Vervoorn
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Nov 2019 12:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment