Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration
......................................................................
Patch Set 34:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi...
File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi...
PS2, Line 301: emi_mdl_init
Because it will be easier to revert/reland patches, and easier to rename functions. […]
Yes, emi_mdl_init is removed from CB:44699, it will be added in this patch.
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi...
PS2, Line 374: 2
Still wrong link?
emi_init func is at line: 293 in this file.
static void emi_init(void)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b778698a09c999252fef3153ac1e869ea9d90cd
Gerrit-Change-Number: 44703
Gerrit-PatchSet: 34
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xi Chen
xixi.chen@mediatek.com
Gerrit-Comment-Date: Thu, 03 Dec 2020 06:48:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Duan huayang
huayang.duan@mediatek.com
Gerrit-MessageType: comment