Matthew Ziegelbaum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47556 )
Change subject: mb/google/hatch/var/ambassador: update fan table and usb configs ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47556/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47556/1//COMMIT_MSG@7 PS1, Line 7: ambassador
mb/google/hatch/var/ambassador: …
Done
https://review.coreboot.org/c/coreboot/+/47556/1//COMMIT_MSG@8 PS1, Line 8:
Please describe the problem, and where you got the values from.
Done
https://review.coreboot.org/c/coreboot/+/47556/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/ambassador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47556/1/src/mainboard/google/hatch/... PS1, Line 3: egister "HeciEnabled" = "1"
intentionally dropped? Probably because you are enabling 16. […]
Yes--I had cherrypicked https://review.coreboot.org/plugins/gitiles/coreboot/+/50a1072180f05c20ec13d... before it was submitted, and then forgot when I uploaded the CL. Rebased now.