Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37516 )
Change subject: mb/facebook/monolith: Add Facebook Monolith ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37516/2/Documentation/mainboard/fac... File Documentation/mainboard/facebook/monolith.md:
https://review.coreboot.org/c/coreboot/+/37516/2/Documentation/mainboard/fac... PS2, Line 22: , whose datasheet can be found : [here][W25Q128JVSIQ] Just use
([datasheet][W25Q128JVSIQ])
https://review.coreboot.org/c/coreboot/+/37516/2/Documentation/mainboard/fac... PS2, Line 51: - SeaBIOS payload What commit?
https://review.coreboot.org/c/coreboot/+/37516/2/Documentation/mainboard/fac... PS2, Line 52: - TianoCore payload Which one exactly?
https://review.coreboot.org/c/coreboot/+/37516/2/Documentation/mainboard/fac... PS2, Line 53: - LinuxBoot Ditto.
https://review.coreboot.org/c/coreboot/+/37516/2/Documentation/mainboard/fac... PS2, Line 59: KabyLake Kaby Lake