3 Jan
2020
3 Jan
'20
7:41 a.m.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38127 )
Change subject: mb/ibase/mb899: Reformat code ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38127/3/src/mainboard/ibase/mb899/s... File src/mainboard/ibase/mb899/superio_hwm.c:
https://review.coreboot.org/c/coreboot/+/38127/3/src/mainboard/ibase/mb899/s... PS3, Line 33: //#define FAN_TEMPERATURE_30DEGC 0 Why not remove this line? Or replace TAB by SPACE
https://review.coreboot.org/c/coreboot/+/38127/3/src/mainboard/ibase/mb899/s... PS3, Line 74: // get_option(&cpufan_temperature, "cpufan_temperature"); Same: Why not remove these lines
--
To view, visit https://review.coreboot.org/c/coreboot/+/38127
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c131b8dc6308ed813820f67477d157ccea5b05
Gerrit-Change-Number: 38127
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Jan 2020 06:41:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment