Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38458 )
Change subject: mainboard/google/puff: update SATA strength
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38458/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38458/2/src/mainboard/google/hatch/...
PS2, Line 127: register "sata_port[1].TxGen3DeEmph" = "0x20"
Add comment what 0x20?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38458
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82b7e5df32b4ce794682781f33c44dfeb6e68bf
Gerrit-Change-Number: 38458
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chen
Tim-Chen@quantatw.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Tim Chen
tim-chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jan 2020 10:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment