Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45560 ) Change subject: soc/intel/common/basecode: Move block/acpi to basecode/acpi ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/acpi.... File src/soc/intel/skylake/acpi.c: https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/acpi.... PS6, Line 201: unsigned long acpi_fill_mcfg(unsigned long current)
Yes Furquan, i didn't realize that SKL was not using common block for ACPI hence it create problem. […] Well, I started working on moving skl to acpi common code in CB:44138. Feel free to continue there, if you wish
-- To view, visit https://review.coreboot.org/c/coreboot/+/45560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia18ee1a8c5e795f9dbbc086cb6b39fbf59fc1655 Gerrit-Change-Number: 45560 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Reviewer: David Guckian <david.guckian@intel.com> Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de> Gerrit-CC: Subrata Banik <subi.banik@gmail.com> Gerrit-Comment-Date: Sun, 20 Sep 2020 20:41:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subi.banik@gmail.com> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: comment