Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 )
Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller
......................................................................
Patch Set 3:
Only remaining option is to use coreboot's ssdt generator.
Or test _STA method proper.
_STA is against the ACPI spec in case of PCI device. i don't
understand whats the point of pushing in that line ?
Because I couldn't find anything in ACPI spec telling that. Can
you point me to the specific paragraph, please?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c0230e845c8d02386b50b1100faf7064ecf8f6
Gerrit-Change-Number: 30614
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 28 Jan 2019 11:01:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment