Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/59578
to review the following change.
Change subject: elogtool: Add a subtype under Chrome OS diagnostics event ......................................................................
elogtool: Add a subtype under Chrome OS diagnostics event
Add a subtype under Chrome OS diagnostics events: * ELOG_CROS_UPLOAD(0x00): sub-type for marking the metrics for Chrome OS diagnostics is uploaded to UMA services. This event will be added in Chrome OS with elogtool since we could only upload to UMA there.
Change-Id: I5c52d0cefb1a12597b26545014aa41527e99eb13 Signed-off-by: Hsuan Ting Chen roccochen@chromium.org --- M src/commonlib/bsd/include/commonlib/bsd/elog.h M util/cbfstool/eventlog.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/59578/1
diff --git a/src/commonlib/bsd/include/commonlib/bsd/elog.h b/src/commonlib/bsd/include/commonlib/bsd/elog.h index 29c781b..199694b 100644 --- a/src/commonlib/bsd/include/commonlib/bsd/elog.h +++ b/src/commonlib/bsd/include/commonlib/bsd/elog.h @@ -307,6 +307,7 @@
/* Chrome OS diagnostics-related events */ #define ELOG_TYPE_CROS_DIAGNOSTICS 0xb6 +#define ELOG_CROS_UPLOAD 0x00 #define ELOG_CROS_LAUNCH_DIAGNOSTICS 0x01
struct elog_event_extended_event { diff --git a/util/cbfstool/eventlog.c b/util/cbfstool/eventlog.c index 1fd4113..e873e82 100644 --- a/util/cbfstool/eventlog.c +++ b/util/cbfstool/eventlog.c @@ -535,6 +535,7 @@ };
static const struct valstr cros_diagnostics_types[] = { + {ELOG_CROS_UPLOAD, "Upload Metrics"}, {ELOG_CROS_LAUNCH_DIAGNOSTICS, "Launch Diagnostics"}, {0, NULL}, };