Attention is currently required from: Raul Rangel, Jon Murphy, Eric Lai, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 )
Change subject: mb/google/myst: Enable chromeOS EC ......................................................................
Patch Set 5:
(6 comments)
File src/mainboard/google/myst/Kconfig:
https://review.coreboot.org/c/coreboot/+/74099/comment/3e61b0bd_7effa35a PS5, Line 19: : config CHROMEOS : select EC_GOOGLE_CHROMEEC_SWITCHES Why is this different from Skyrim, which doesn't have `config CHROMEOS`?
``` config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES ```
https://review.coreboot.org/c/coreboot/+/74099/comment/168769d6_05964af6 PS5, Line 29: config IGNORE_IASL_MISSING_DEPENDENCY : def_bool y What is this? I don't see it in code search.
File src/mainboard/google/myst/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/74099/comment/98796c65_9aa360ce PS5, Line 26: | EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC)) Missing: `EC_HOST_EVENT_BODY_DETECT_CHANGE`
https://review.coreboot.org/c/coreboot/+/74099/comment/4d29fa39_cb8f8d74 PS5, Line 58: #define EC_SCI_GPI GEVENT_24 /* eSPI system event -> GPE 24 */ GPE11?
https://docs.google.com/spreadsheets/d/1otkDb3R0ggaSoQcI4nRw9v07Jeb37JXZbjjq...
https://review.coreboot.org/c/coreboot/+/74099/comment/03833ac6_0afdcab1 PS5, Line 62: #define EC_ENABLE_WAKE_PIN GEVENT_5 /* AGPIO 11 -> GPE 5 */ `GEVENT_5` is not listed, but neither is the lid switch, unless there's some abreviation I'm missing.
https://review.coreboot.org/c/coreboot/+/74099/comment/212e5a5f_8af75f33 PS5, Line 76: #define EC_SYNC_IRQ GPIO_84 I'm not sure what the "sync" IRQ is, but GPIO 74 is `FANIN0`.