Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33855 )
Change subject: libpayload: cbgfx: Run cbgfx_init() before we need it for draw_box()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33855/1/payloads/libpayload/drivers/video/gr...
File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/#/c/33855/1/payloads/libpayload/drivers/video/gr...
PS1, Line 190: const uint32_t color
You don't get "declaration must be at beginning of a block" error?
libpayload is built with -std=gnu11, so no.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73ca8e20ca36f64d699379d504fd41dc2084f157
Gerrit-Change-Number: 33855
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 29 Jun 2019 00:31:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-MessageType: comment