Attention is currently required from: Angel Pons, Kyösti Mälkki.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70041 )
Change subject: arch/x86: Add bitwise operations for IO space
......................................................................
Patch Set 2:
(1 comment)
File src/arch/x86/include/arch/io_bitops.h:
https://review.coreboot.org/c/coreboot/+/70041/comment/a69d945c_2b1a549a
PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Do we really want this file to be called 'io_bitops.h'? It provides general read/write functions as well and I find it a bit misleading. How about io_ops.h instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e1146f062dced1b75195846ea65a44e2bd4482
Gerrit-Change-Number: 70041
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment