Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )
Change subject: mb/google/kukui: Add panels for Krane
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui...
File src/mainboard/google/kukui/panel_krane.c:
https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui...
PS15, Line 357: static struct panel_description *krane_panels[] = {
let's do that later when we find this really needed. […]
I did some experiment and found it not being very easy/clean at the moment.
The major reason is to load from CBFS we have to know the size first. SDRAM_config is usually in fixed size (or at least knowing the maximum). The table above may vary a lot and hard to define a size for it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Gerrit-Change-Number: 33413
Gerrit-PatchSet: 16
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nicolas Boichat
drinkcat@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 05 Aug 2019 02:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment