Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48446 )
Change subject: mb/google/brya: Add memory DQ map
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48446/1/src/mainboard/google/brya/v...
File src/mainboard/google/brya/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/48446/1/src/mainboard/google/brya/v...
PS1, Line 7: lpddr4x_cfg
If they don't have intend to follow TGL, I can follow the adlrvp to change this.
I had talked to Subrata about keeping this similar to TGL and hence the bug. If you have cycles, I would recommend taking the bug up since it keeps things simpler in the mainboard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94102240b13d2b95e0295f41bc2c0ba078faf242
Gerrit-Change-Number: 48446
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Dec 2020 22:24:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment