Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30976 )
Change subject: mediatek/mt8183: Add I2C driver code ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30976/1/src/soc/mediatek/mt8183/i2c... File src/soc/mediatek/mt8183/i2c.c:
https://review.coreboot.org/c/coreboot/+/30976/1/src/soc/mediatek/mt8183/i2c... PS1, Line 115: CONN_TOP_DATA
should be SDA6, SCL6 ?
Ack
https://review.coreboot.org/c/coreboot/+/30976/6/src/soc/mediatek/mt8183/i2c... File src/soc/mediatek/mt8183/i2c.c:
https://review.coreboot.org/c/coreboot/+/30976/6/src/soc/mediatek/mt8183/i2c... PS6, Line 128: assert(bus < I2C_BUS_NUMBER && bus != 7);
After confirmation, there is no need for i2c7 i2c8 upstream. We will remove them.
Ack